refactor(test_utils): Refactor test_utils crate and add folder support with updated documentation
#2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-CI-CD
pixincreate
requested review from
knutties,
SanchithHegde,
likhinbopanna and
Gnanasundari24
SanchithHegde
approved these changes
Oct 9, 2023
bernard-eugine
modified the milestones:
September 2023 Milestone,
October 2023 Milestone
likhinbopanna
approved these changes
Oct 10, 2023
pixincreate
removed
the
S-waiting-on-review
knutties
reviewed
Oct 10, 2023
|
|
||
| newman_command.arg("--delay-request").arg("7"); // 7 milli seconds delay | ||
|
|
||
| newman_command.arg("--color").arg("on"); |
There was a problem hiding this comment.
It will be a good idea to expose all postman run options via this CLI - might be useful at some time. things like delay-request and timeout would be useful.
There was a problem hiding this comment.
Sure! I'll raise another PR soon addressing this since this is already merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR completely refactors
Rustman(newman-fork within Rust wrapper) that aims to de-clutter the runner thereby making it more readable and intuitive. Also, added support for runningfoldersindividually instead of running the whole thing every time (If the folder that you wish to run does not containQuickStartfolder, it will be added automatically during run-time to avoidUnauthorizederrors).In addition to this, documentation has also been updated w.r.t the changes done.
Motivation and Context
This had to be done as many of the developers who were affected asked for it.
The main issue was that, if the Postman CI checks failed, there exist no way to do a RCA in an instant. You're forced to -- Manually check the failure point from the available logs from the CI, import the collection in Postman, run
QuickStartfollowed by the folder causing the problem or anything as such since you cannot run individual folders through Test Utils (Rustman).Increased complexity in
main.rsforced me to move it to another file.How did you test it?
Ran a specific folder and it worked without any issues:
Ran Stripe collection:
Checklist
cargo +nightly fmt --allcargo clippy