-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): change temp locker config as enable only #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-harsha-vardhan
added
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Oct 10, 2023
sai-harsha-vardhan
requested review from
ArjunKarthik,
jarnura and
Narayanbhat166
October 10, 2023 06:45
bernard-eugine
modified the milestones:
September 2023 Milestone,
October 2023 Milestone
Oct 10, 2023
…hyperswitch into change-temp-locker-enable-config
ArjunKarthik
approved these changes
Oct 10, 2023
Comment on lines
-304
to
-306
utils::when(payment_method_data.is_none(), || { | ||
Err(errors::ApiErrorResponse::PaymentMethodNotFound) | ||
})?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this removed?
Narayanbhat166
approved these changes
Oct 10, 2023
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
change temp locker config as enable only, temp locker would be utilized only for specific connector <> payment_method which is enabled through env
Additional Changes
Motivation and Context
How did you test it?
Tested Manually
Enable temp locker for stripe cards
Remove cards payment_method from config
Checklist
cargo +nightly fmt --all
cargo clippy