Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve fixmes in router/scheduler #269

Merged
merged 4 commits into from
Jan 4, 2023
Merged

fix: resolve fixmes in router/scheduler #269

merged 4 commits into from
Jan 4, 2023

Conversation

NishantJoshi00
Copy link
Member

Type of Change

  • Enhancement

Description

This change resolves several FIXMEs and TODOs that are present in the scheduler. No major changes are included in this PR only code reordering and performance enhancement and undertaken

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

N/A

How did you test it?

Code refactoring and relocation.

Checklist

  • I formatted the code cargo +nightly fmt
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-process-tracker Area: Process tracker S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Jan 2, 2023
@NishantJoshi00 NishantJoshi00 self-assigned this Jan 2, 2023
@NishantJoshi00 NishantJoshi00 changed the title fix: resolve fixmes and/or assign issues to fixmes fix: resolve fixmes in router/scheduler Jan 2, 2023
@jarnura jarnura added S-awaiting-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-awaiting-merge labels Jan 3, 2023
@jarnura jarnura merged commit 9a47582 into main Jan 4, 2023
@jarnura jarnura deleted the scheduler-fix branch January 4, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@NishantJoshi00 NishantJoshi00

Labels
A-process-tracker Area: Process tracker C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NishantJoshi00 @jarnura @SanchithHegde