Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Prophetpay] Save card token for Refund and remove Void flow #2927

Merged
merged 8 commits into from
Nov 21, 2023
Merged

feat(connector): [Prophetpay] Save card token for Refund and remove Void flow #2927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0239d79
refactor: seperate try_from for each flow
Sakilmostak Nov 20, 2023
42745c9
refactor: remove void flow
Sakilmostak Nov 20, 2023
2a12332
feat: save card token in metadata
Sakilmostak Nov 20, 2023
4fe1325
refactor: remove validation used for testing
Sakilmostak Nov 20, 2023
bf76dc5
refactor: void flow and reference id
Sakilmostak Nov 21, 2023
eb745a7
refactor: comments
Sakilmostak Nov 21, 2023
631f48e
refactor: clippy errors
Sakilmostak Nov 21, 2023
d565e7d
Merge branch 'main' into prop_pay_add
Sakilmostak Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 21 additions & 26 deletions crates/router/src/connector/prophetpay.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,16 +107,15 @@ impl ConnectorCommon for Prophetpay {
&self,
res: Response,
) -> CustomResult<ErrorResponse, errors::ConnectorError> {
let response: prophetpay::ProphetpayErrorResponse = res
let response: serde_json::Value = res
.response
.parse_struct("ProphetpayErrorResponse")
.parse_struct("ProphetPayErrorResponse")
.change_context(errors::ConnectorError::ResponseDeserializationFailed)?;

Ok(ErrorResponse {
status_code: res.status_code,
code: response.status.to_string(),
message: response.title,
reason: Some(response.errors.to_string()),
code: consts::NO_ERROR_CODE.to_string(),
message: consts::NO_ERROR_MESSAGE.to_string(),
reason: Some(response.to_string()),
attempt_status: None,
})
}
Expand Down Expand Up @@ -324,7 +323,7 @@ impl
where
types::PaymentsResponseData: Clone,
{
let response: prophetpay::ProphetpayResponse = res
let response: prophetpay::ProphetpayCompleteAuthResponse = res
.response
.parse_struct("prophetpay ProphetpayResponse")
.change_context(errors::ConnectorError::ResponseDeserializationFailed)?;
Expand Down Expand Up @@ -407,9 +406,9 @@ impl ConnectorIntegration<api::PSync, types::PaymentsSyncData, types::PaymentsRe
data: &types::PaymentsSyncRouterData,
res: Response,
) -> CustomResult<types::PaymentsSyncRouterData, errors::ConnectorError> {
let response: prophetpay::ProphetpayResponse = res
let response: prophetpay::ProphetpaySyncResponse = res
.response
.parse_struct("prophetpay ProphetpayResponse")
.parse_struct("prophetpay PaymentsSyncResponse")
.change_context(errors::ConnectorError::ResponseDeserializationFailed)?;
types::RouterData::try_from(types::ResponseRouterData {
response,
Expand All @@ -431,9 +430,12 @@ impl ConnectorIntegration<api::Capture, types::PaymentsCaptureData, types::Payme
{
}

// This is Void Implementation for Prophetpay
// Since Prophetpay does not have capture this have been commented out but kept if it is required for future usage
impl ConnectorIntegration<api::Void, types::PaymentsCancelData, types::PaymentsResponseData>
for Prophetpay
{
/*
fn get_headers(
&self,
req: &types::PaymentsCancelRouterData,
Expand Down Expand Up @@ -471,33 +473,25 @@ impl ConnectorIntegration<api::Void, types::PaymentsCancelData, types::PaymentsR
.change_context(errors::ConnectorError::RequestEncodingFailed)?;
Ok(Some(prophetpay_req))
}
*/

fn build_request(
&self,
req: &types::PaymentsCancelRouterData,
connectors: &settings::Connectors,
_req: &types::PaymentsCancelRouterData,
_connectors: &settings::Connectors,
) -> CustomResult<Option<services::Request>, errors::ConnectorError> {
Ok(Some(
services::RequestBuilder::new()
.method(services::Method::Get)
.url(&types::PaymentsVoidType::get_url(self, req, connectors)?)
.attach_default_headers()
.headers(types::PaymentsVoidType::get_headers(self, req, connectors)?)
.body(types::PaymentsVoidType::get_request_body(
self, req, connectors,
)?)
.build(),
))
Err(errors::ConnectorError::NotImplemented("Void flow not implemented".to_string()).into())
}

/*
fn handle_response(
&self,
data: &types::PaymentsCancelRouterData,
res: Response,
) -> CustomResult<types::PaymentsCancelRouterData, errors::ConnectorError> {
let response: prophetpay::ProphetpayResponse = res
let response: prophetpay::ProphetpayVoidResponse = res
.response
.parse_struct("prophetpay ProphetpayResponse")
.parse_struct("prophetpay PaymentsCancelResponse")
.change_context(errors::ConnectorError::ResponseDeserializationFailed)?;
types::RouterData::try_from(types::ResponseRouterData {
response,
Expand All @@ -512,6 +506,7 @@ impl ConnectorIntegration<api::Void, types::PaymentsCancelData, types::PaymentsR
) -> CustomResult<ErrorResponse, errors::ConnectorError> {
self.build_error_response(res)
}
*/
}

impl ConnectorIntegration<api::Execute, types::RefundsData, types::RefundsResponseData>
Expand Down Expand Up @@ -652,7 +647,7 @@ impl ConnectorIntegration<api::RSync, types::RefundsData, types::RefundsResponse
) -> CustomResult<Option<services::Request>, errors::ConnectorError> {
Ok(Some(
services::RequestBuilder::new()
.method(services::Method::Get)
.method(services::Method::Post)
.url(&types::RefundSyncType::get_url(self, req, connectors)?)
.attach_default_headers()
.headers(types::RefundSyncType::get_headers(self, req, connectors)?)
Expand All @@ -668,7 +663,7 @@ impl ConnectorIntegration<api::RSync, types::RefundsData, types::RefundsResponse
data: &types::RefundSyncRouterData,
res: Response,
) -> CustomResult<types::RefundSyncRouterData, errors::ConnectorError> {
let response: prophetpay::ProphetpayRefundResponse = res
let response: prophetpay::ProphetpayRefundSyncResponse = res
.response
.parse_struct("prophetpay ProphetpayRefundResponse")
.change_context(errors::ConnectorError::ResponseDeserializationFailed)?;
Expand Down
Loading
Loading