-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(users): Email JWT blacklist #3659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racnan
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-users
Area: Users
labels
Feb 15, 2024
Closed
ThisIsMani
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions
ThisIsMani
previously approved these changes
Feb 15, 2024
ThisIsMani
approved these changes
Feb 15, 2024
NishantJoshi00
approved these changes
Feb 15, 2024
let redis_conn = get_redis_connection(state).change_context(UserErrors::InternalServerError)?; | ||
let blacklist_key = format!("{}{token}", EMAIL_TOKEN_BLACKLIST_PREFIX); | ||
let key_exists = redis_conn | ||
.exists::<()>(blacklist_key.as_str()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
likhinbopanna
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Feb 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
Prevention of use of same email link to be used twice.
Forcing Users to re-enter password if password is changed.
How did you test it?
With Dashboard Frontend.
Following links should not work twice:
To generate magic link email use dashboard frontend or below curl.
To generate reset password email use dashboard frontend or below curl.
All sessions should be logged out after change password or reset password.
Expected error response for the use of email token twice
Checklist
cargo +nightly fmt --all
cargo clippy