fix(loadtest): rename [database] to [master_database] in config file
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanchithHegde
added
C-bug
SanchithHegde
requested review from
jarnura,
lsampras,
dracarys18 and
ashokkjag
dracarys18
approved these changes
Nov 28, 2022
jarnura
approved these changes
Nov 29, 2022
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This is an extension to #4; fixes one instance of
[database]inloadtest/config/Development.tomlwhich seems to have been left out during the refactor.Additional Changes
N/A
Motivation and Context
I was trying to run loadtests and the
routerservice was unable to connect to the database; this turned out to be the cause.How did you test it?
Ran
docker compose up -dinloadtestdirectory.Checklist
cargo +nightly fmtcargo clippy