-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): store network_reference_id
against the payment_method_id
in the payment_method_table
#4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShankarSinghC
added
A-core
Area: Core flows
A-payment-methods
Area: Payment Methods
A-payments
Area: payments
labels
Mar 12, 2024
ShankarSinghC
changed the title
feat(router):Store Network Reference ID against the Payment Method ID in the
feat(router): store Mar 12, 2024
payment_method_table
network_reference_id
against the payment_method_id in the payment_method_table
ShankarSinghC
changed the title
feat(router): store
feat(router): store Mar 12, 2024
network_reference_id
against the payment_method_id in the payment_method_table
network_reference_id
against the payment_method_id
in the payment_method_table
jagan-jaya
previously approved these changes
Apr 3, 2024
jagan-jaya
previously approved these changes
Apr 3, 2024
… into nrid/store-nrid
jagan-jaya
previously approved these changes
Apr 3, 2024
Aprabhat19
previously approved these changes
Apr 3, 2024
… into nrid/store-nrid
ShankarSinghC
dismissed stale reviews from Aprabhat19 and jagan-jaya
via
April 4, 2024 07:31
1d2dd9c
Narayanbhat166
approved these changes
Apr 4, 2024
Aprabhat19
approved these changes
Apr 4, 2024
jagan-jaya
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
During the CIT there needs to be a validation which check for the setup_future_usage field, if it is set to off_session the NRID returned from the connector needs to be stored against the particular payment_method_id in the network_transaction_id column of the payment_methods table.
Additional Changes
Motivation and Context
How did you test it?
Create a Merchant account
Create a mca for stripe, adyen or cybersource
Create a mandate payment (Setup mandate)
Once the mandate is successful the network_transaction_id is stored as below
network_transaction_id
being stored inpayment_method
tableChecklist
cargo +nightly fmt --all
cargo clippy