refactor(stripe): use bearer explictly when calling connectors #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narayanbhat166
added
S-waiting-on-review
Narayanbhat166
changed the title
Narayanbhat166
changed the title
bernard-eugine
approved these changes
Jan 19, 2023
lsampras
approved these changes
Jan 19, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR will refactor
stripeandcheckoutrequest to send the token asBearerinstead of asking merchant to add the token type while creating the token.Motivation and Context
Instead of requesting the merchant to provide this information for a connector, since we have all information of how to send a request to connector, it is better if this is done in the code.
How did you test it?
Create a connector account with just the api key, without token type ( Bearer or Basic added )
Create a payment
Checklist
cargo +nightly fmt --allcargo clippy