Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [ZSL] Add base_url to Environments #4344

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

Sakilmostak
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Base url was missing for Zsl connector for prod, sandbox and integ env

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

No testing required

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-bug Category: Bug labels Apr 12, 2024
@Sakilmostak Sakilmostak self-assigned this Apr 12, 2024
@Sakilmostak Sakilmostak requested a review from a team as a code owner April 12, 2024 07:26
@likhinbopanna likhinbopanna added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit 91830f6 Apr 12, 2024
10 of 12 checks passed
@likhinbopanna likhinbopanna deleted the add_base_url_zsl branch April 12, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants