-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(payment_methods): log and ignore the apple pay metadata parsing error while fetching apple pay retry connectors #4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror while fetching apple pay retry connectors
|
||
Ok( | ||
if let Some(apple_pay_metadata) = option_apple_pay_metadata { | ||
match apple_pay_metadata { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we try to eliminate this match statement using matches!?
sai-harsha-vardhan
previously approved these changes
May 24, 2024
sai-harsha-vardhan
approved these changes
May 24, 2024
vspecky
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
For a merchant account there are be n number of connectors and its not mandatory that apple pay needs to be enabled for all of them. So while fetching apple pay retry connectors log the error if the apple pay metadata parsing fails. This is required as this will create unnecessary errors for the connectors that does not have the apple pay metadata enabled as for them apple pay metadata will be not there.
Additional Changes
Motivation and Context
How did you test it?
-> Create a merchant account
-> Enable gcm for the
merchant_id
-> Set the maximum retries count
-> Create MCA for stripe and cybersource with apple pay simplified flow
metadata for simplified flow
-> Do a apple pay payment create with confirm false
-> Confirm the above create payment with
payment_id
and payment_dataChecklist
cargo +nightly fmt --all
cargo clippy