feat(router): added request body for stripe capture request which now accepts amount to capture #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… accepts amount_to_capture
… accepts amount_to_capture
SanchithHegde
previously approved these changes
Nov 30, 2022
| types::PaymentsRequestCaptureData, | ||
| types::PaymentsResponseData, | ||
| >, | ||
| req: &types::PaymentsRouterCaptureData, |
There was a problem hiding this comment.
This type would be called PaymentsCaptureRouterData due to the change in #48. Just bringing it to your notice...
There was a problem hiding this comment.
@Narayanbhat166 agreed to change this once it is merged in main.
SanchithHegde
added
A-connector-integration
jarnura
reviewed
Dec 1, 2022
jarnura
added
the
S-waiting-on-author
Abhicodes-crypto
added
S-waiting-on-review
…hich now accepts amount_to_capture" This reverts commit 37cf48e.
Abhicodes-crypto
requested review from
jarnura,
SanchithHegde and
Narayanbhat166
jarnura
approved these changes
Dec 1, 2022
jarnura
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
For the capture flow in stripe, get_request_body function was added.
Additional Changes
Motivation and Context
This change helps merchant to capture partial funds.
How did you test it?
Tested on postman.
Checklist
cargo +nightly fmtcargo clippy