feat(routing): success based routing metrics #5951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chethan-rao
requested changes
Sep 24, 2024
Chethan-rao
requested changes
Sep 25, 2024
prajjwalkumar17
force-pushed
the
dr_metrics
branch
from
4b55ae3
to
231ad25
Compare
NishantJoshi00
requested changes
Sep 25, 2024
| ); | ||
|
|
||
| let success_based_connectors = client | ||
| .calculate_success_rate( |
There was a problem hiding this comment.
why is this function not accepting &str?
There was a problem hiding this comment.
cc: @Aprabhat19
There was a problem hiding this comment.
For id_type we are anyhow passing a String value to the service, so that's why we chose not to pass a &str and then clone the value later
NishantJoshi00
approved these changes
Sep 25, 2024
Chethan-rao
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR will enable logging of metrics for Dynamic Routing feature. This will be an async call inside the post_update_tracker.
Additional Changes
Motivation and Context
How did you test it?
Once the PR goes to sandbox a grafana dashboard will be created.
tested the metrics (
DYNAMIC_SUCCESS_BASED_ROUTING) in local Grafana. Here is the screenshot for the same:Checklist
cargo +nightly fmt --allcargo clippy