feat(router): add payment_intent_data and modify api models of create intent request and response for v2 #6016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperswitch-bot
bot
added
the
M-api-contract-changes
sai-harsha-vardhan
changed the title
sai-harsha-vardhan
added
A-core
sai-harsha-vardhan
requested review from
jarnura,
SanchithHegde and
Narayanbhat166
…witch into add-payment-intent-data-v2
jarnura
requested changes
Sep 25, 2024
| /// Tax details related to the order. This will be calculated by the external tax provider | ||
| tax_details: Option<TaxDetails>, | ||
| pub tax_details: Option<TaxDetails>, |
There was a problem hiding this comment.
In api_model we have order_tax_amount and in domain_model we have tax_details, lets keep one name to denote these.
There was a problem hiding this comment.
In api_models, we'll be having order_tax_amount only where as in domain models we have default and pmt tax
jarnura
previously approved these changes
Sep 25, 2024
SanchithHegde
previously approved these changes
Sep 25, 2024
sai-harsha-vardhan
dismissed stale reviews from SanchithHegde and jarnura
via
5f339ab
Narayanbhat166
approved these changes
Sep 25, 2024
jarnura
approved these changes
Sep 25, 2024
SanchithHegde
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add payment_intent_data and modify api models of create intent request and response for v2
Additional Changes
Motivation and Context
How did you test it?
Compiler guided (api model changes only)
Checklist
cargo +nightly fmt --allcargo clippy