Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic nix support #63

Merged
merged 4 commits into from
Dec 7, 2022
Merged

feat: add basic nix support #63

merged 4 commits into from
Dec 7, 2022

Conversation

aravindgopall
Copy link
Contributor

@aravindgopall aravindgopall commented Dec 5, 2022

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Adding basic support for nix. This PR gives nix shell with cargo, rustc - 1.63.0. Plan is to make use of nix to do full dev setup.

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes #57.

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@aravindgopall
Copy link
Contributor Author

#57

@SanchithHegde SanchithHegde changed the title Added basic support for nix. That creates the dev shell with basic to… add basic nix support Dec 5, 2022
@SanchithHegde SanchithHegde changed the title add basic nix support feat: add basic nix support Dec 5, 2022
@SanchithHegde SanchithHegde added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 5, 2022
@jarnura jarnura removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 7, 2022
@aravindgopall
Copy link
Contributor Author

We can have this PR merged and focus on making it better in future PR's. Update of ReadME for development is TBD.

 nix develop .
 cargo build

@jarnura jarnura merged commit bbe3040 into main Dec 7, 2022
@jarnura jarnura deleted the aravindgopall/nix-support branch December 7, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nix Support
3 participants