refactor: Pass country and currency as json format in MCA #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoj-juspay
added
S-waiting-on-review
manoj-juspay
requested review from
jarnura,
SanchithHegde,
ashokkjag and
bernard-eugine
12 tasks
jarnura
requested changes
Feb 26, 2023
jarnura
approved these changes
Feb 26, 2023
lsampras
approved these changes
Feb 26, 2023
| pub enable_only: Option<Vec<String>>, | ||
| /// Type of accepted countries (disable_only, enable_only) | ||
| #[serde(rename = "type")] | ||
| pub accept_type: String, |
| #[serde(rename = "type")] | ||
| pub accept_type: String, | ||
| /// List of countries of the provided type | ||
| pub list: Option<Vec<String>>, |
There was a problem hiding this comment.
are these 2 letter country codes?
these could probably be enum as well
| @@ -472,19 +472,25 @@ fn filter_pm_country_based( | |||
| ) -> (Option<admin::AcceptedCountries>, Option<Vec<String>>, bool) { | |||
| match (accepted_countries, req_country_list) { | |||
| (None, None) => (None, None, true), | |||
| (None, Some(ref r)) => (None, Some(r.to_vec()), false), | |||
| (None, Some(ref r)) => ( | |||
There was a problem hiding this comment.
do we need ref seems you should be able to consume the value instead of ref + to_owned
jarnura
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Supported country and currency , the size exceed the allowed request size, refactoring how these field are passed in the MCA and in the List PM api
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy