Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pm_list): support for sending bank names #678

Merged
merged 6 commits into from
Feb 27, 2023
Merged

feat(pm_list): support for sending bank names #678

merged 6 commits into from
Feb 27, 2023

Conversation

Narayanbhat166
Copy link
Member

Type of Change

  • New feature

Description

Support sending bank_codes in payment_method list endpoint.

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Manual

{
    "redirect_url": "https://www.example.com/success",
    "payment_methods": [
        {
            "payment_method": "bank_redirect",
            "payment_method_types": [
                {
                    "payment_method_type": "eps",
                    "payment_experience": null,
                    "card_networks": null,
                    "bank_names": [
                        {
                            "bank_name": [
                                "bks_bank_ag",
                                "btv_vier_lander_bank",
                                "brull_kallmus_bank_ag",
                                "bankhaus_schelhammer_und_schattera_ag",
                                "arzte_und_apotheker_bank",
                                "austrian_anadi_bank_ag",
                                "bawag_psk_ag"
                            ],
                            "eligible_connectors": [
                                "stripe"
                            ]
                        }
                    ]
                }
            ]
        }
    ]
}

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@Narayanbhat166 Narayanbhat166 added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 27, 2023
@Narayanbhat166 Narayanbhat166 self-assigned this Feb 27, 2023
@Narayanbhat166 Narayanbhat166 changed the title Feat/bank name feat(pm_list): support for sending bank names Feb 27, 2023
crates/router/src/core/payment_methods/cards.rs Outdated Show resolved Hide resolved
crates/router/src/core/payment_methods/cards.rs Outdated Show resolved Hide resolved
@jarnura jarnura removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 27, 2023
@jarnura jarnura merged commit 576f8e1 into main Feb 27, 2023
@jarnura jarnura deleted the feat/bank_name branch February 27, 2023 20:29
vspecky pushed a commit that referenced this pull request Feb 28, 2023
Co-authored-by: dracarys18 <karthikey.hegde@juspay.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants