Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): remove enabled payment methods from list customer payment … #689

Merged
merged 1 commit into from
Feb 28, 2023
Merged

fix(list): remove enabled payment methods from list customer payment … #689

merged 1 commit into from
Feb 28, 2023

Conversation

NishantJoshi00
Copy link
Member

…method

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Removes the enabled payment method field from list_customer_payment_method. This is an extension to the PR raised by @Narayanbhat166

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 28, 2023
@NishantJoshi00 NishantJoshi00 self-assigned this Feb 28, 2023
@NishantJoshi00 NishantJoshi00 requested review from a team as code owners February 28, 2023 12:46
Narayanbhat166
Narayanbhat166 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@Narayanbhat166 Narayanbhat166 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarnura jarnura removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 28, 2023
@jarnura jarnura merged commit 5c29f37 into main Feb 28, 2023
@jarnura jarnura deleted the fix-output-customer-pm branch February 28, 2023 12:59
@NishantJoshi00 NishantJoshi00 mentioned this pull request Mar 1, 2023
Merged
12 tasks
@jarnura jarnura mentioned this pull request Mar 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

@bernard-eugine bernard-eugine Awaiting requested review from bernard-eugine

Assignees

@NishantJoshi00 NishantJoshi00

Labels
A-core Area: Core flows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NishantJoshi00 @jarnura @Narayanbhat166