nix_rs: Don't hardcode flake schema types #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will also have to re-think this design based on how it will be used in #222, to parse |
shivaraj-bh
changed the title
schema module; Enable generic schemas lookup from FlakeOutputs
srid
added a commit
that referenced
this pull request
Sep 23, 2024
- Use `#![warn(missing_docs)]` to enforce that all public entites are documented - Make an exception for `schema.rs` & `output.rs` since those can be documented as part of #235
srid
reviewed
Sep 23, 2024
srid
added a commit
that referenced
this pull request
Sep 23, 2024
- Use `#![warn(missing_docs)]` to enforce that all public entites are documented - Make an exception for `schema.rs` & `output.rs` since those can be documented as part of #235
srid
reviewed
Sep 23, 2024
srid
reviewed
Sep 23, 2024
srid
reviewed
Sep 23, 2024
srid
reviewed
Sep 23, 2024
srid
reviewed
Sep 23, 2024
srid
added a commit
that referenced
this pull request
Sep 23, 2024
- Use `#![warn(missing_docs)]` to enforce that all public entites are documented - Make an exception for `schema.rs` & `output.rs` since those can be documented as part of #235
srid
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Just reviewed. @shivaraj-bh Can you merge from main to bring in #283 (removing #![allow(missing_docs)] in the process) and document the new types/ functions accordingly?
(Bear in mind that documentation should be more about general functional semantics than verbatim repetition of types).
shivaraj-bh
commented
Sep 23, 2024
Co-authored-by: Sridhar Ratnakumar <3998+srid@users.noreply.github.com>
srid
reviewed
Sep 23, 2024
Comment on lines
+181
to
+182
| #[serde(other)] | ||
| Unknown, |
There was a problem hiding this comment.
Perhaps this should be Other(String)? Assuming flake-schemas passes the arbitrary type string, that is. Not sure.
There was a problem hiding this comment.
Can address this in different PR. I'm merging this.
The "Option" is not really used by the function. And default handling is typically done by the caller. This function only cares to take FlakeOutput, not the meta struture.
Also rename the function, since 'children' is a superset of what this actually returns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #262
TODO: