Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-Processing test fixes #23

Merged
merged 1 commit into from
Jul 30, 2011
Merged

Pre-Processing test fixes #23

merged 1 commit into from
Jul 30, 2011

Conversation

davidgovea
Copy link
Contributor

  • Capper.createBufferBased needed a channel count
  • Added lfo generate to capper preprocess for dynamic capping
  • Updated title

@jussi-kalliokoski
Copy link
Owner

Oops! Who tests the tester, right? :D

jussi-kalliokoski added a commit that referenced this pull request Jul 30, 2011
@jussi-kalliokoski
Merge pull request #23 from davidgovea/preprocess
475480d 
Pre-Processing test fixes
@jussi-kalliokoski jussi-kalliokoski merged commit 475480d into jussi-kalliokoski:master Jul 30, 2011
@jussi-kalliokoski
Copy link
Owner

I used your test as a template, as you probably noticed. :P

@jussi-kalliokoski
Copy link
Owner

Oh, btw, for audiolib.js I've used hard tabs with width of 8 characters. Don't worry about the code you've already written, I'll take care of that, it's a simple s/ /\t/g . Sorry for nitpicking! :)

@davidgovea
Copy link
Contributor Author

Thanks, I was having a time trying to get the ='s to line up!

@jussi-kalliokoski
Copy link
Owner

Hehe, np, and sorry for the trouble! I did the replace for source code now, for tests it doesn't really matter that much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidgovea @jussi-kalliokoski