This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
Use baseUrl as parameter #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemyslaw-szurmak
approved these changes
Oct 5, 2018
|
I would love this change to be included in |
|
Hi @piotr-adamczak-mobica, thanks for contributing! Nice addition, I'll merge it now. |
ghost
approved these changes
Nov 9, 2018
ghost
merged commit
|
@piotr-adamczak-mobica we also just published a new version (2.4.1) with your changes. |
|
@albertodebortoli-je Thank you so much! :) |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
It would be really helpful if
baseUrlparameter for saving logs as files would be a variable.Why?
Imagine using
App Groupsto sync your log files.With this change all you will need to do this is:
logger.baseUrlForFileLogging = FileManager.default.containerURL(forSecurityApplicationGroupIdentifier: "your-group-id")All best,
Peter