Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.19.0 Updated SVG icons to match international #45

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Conversation

richardimms
Copy link
Contributor

No description provided.

@richardimms richardimms requested a review from a team as a code owner January 31, 2019 11:17
@fozzie-bot
Copy link

fozzie-bot commented Jan 31, 2019

Messages
📖 🔥 👏 You’re a deletion machine!

Generated by 🚫 dangerJS against 20b0c85

Copy link
Contributor

@DamianMullins DamianMullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run these SVGs through SVGOMG, please?

@ashleynolan
Copy link
Contributor

@DamianMullins Pretty sure they already have been, as they're from the International codebase. @richardimms Might be worth checking one and seeing if the resulting SVG comes out the same though

@ashleynolan ashleynolan merged commit 6e64a7a into master Jan 31, 2019
@ashleynolan ashleynolan deleted the v1.19.0 branch January 31, 2019 12:42
@richardimms
Copy link
Contributor Author

Only noticeable difference is that the one from the international codebase has an ID at the beginning.

@DamianMullins
Copy link
Contributor

When I passed one through it stripped out all of the style attributes and reduced the size slightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants