Use NAN for compatibility with Node 0.11+ #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #include <queue> | ||
| #include <uv.h> | ||
|
|
||
| #include "lib/RtMidi/RtMidi.h" | ||
| #include "lib/RtMidi/RtMidi.cpp" | ||
|
|
||
| using namespace node; |
There was a problem hiding this comment.
Seemed really odd to use node's namespace but not v8's. Decided it was probably best to be explicit with node too.
drewish
added a commit
that referenced
this pull request
Feb 11, 2015
Use NAN for compatibility with Node 0.11+
|
I just pushed e53396b which got the builds against 0.10 working again. |
|
Published to npm as v0.9.1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the NAN module to get this working with the new version of node.