error activating virtualenv

[christophlingg]

hi adam,

thanks for your work first! I really like fish and I feel thankful for people who are writing code for it!

I ran into a problem when I activated my first environment:

christoph@christoph ~/k/dev> vf activate myenv
activate myenv
fish: Could not expand string '$argv[0..1]'
/usr/local/bin/virtual.fish (line 49):  echo $argv[0..1]
                                                    ^
in function 'vf',
    called on standard input,
    with parameter list 'activate myenv'

I consulted the fish documentation (I don't know too much about it) and understood your code, but honestly I have no idea why it does not work.

Finally I made a fast but not elegant fix:

        set scargs $argv[2]
        #set scargs $argv[2..-1]

Maybe other people might be affected too? Do you know why the error is popping up?

[daisylb]

What version of fish are you running?

[christophlingg]

fish, version 1.23.1

[fabiant7t]

@christophlingg I was running into the same problem - You can upgrade to fish 2.x (http://fishshell.com/) to solve it.

[daisylb]

Thought that might be the case; I might pop a note about Fish versions on the readme before I close this issue.

Fabian Topfstedt notifications@github.com wrote:

@christophlingg I was running into the same problem - You can upgrade
to fish 2.x (http://fishshell.com/) to solve it.

---

Reply to this email directly or view it on GitHub:
#14 (comment)

Sent from my phone

[christophlingg]

thanks you guys! i am just updating ...

[fabiant7t]

@adambrenecki I guess a lot of people ran and will run into the issue, since e.g. Ubuntu 12.04 LTS ships fish 1.x. If @christophlingg's change makes virtualfish work properly on fish 1.x, I'd rather check if fish --version starts with fish, version 1. and use his line then instead of making everyone upgrade fish?!

[daisylb]

I haven't actually run it, but I'm 99% sure that change will break subcommands that take more than 1 argument.

Fabian Topfstedt notifications@github.com wrote:

@adambrenecki I guess a lot of people ran and will run into the issue,
since e.g. Ubuntu 12.04 LTS ships fish 1.x. If @christophlingg's change
makes virtualfish work properly on fish 1.x, I'd rather check if fish --version starts with fish, version 1. and use his line then instead
of making everyone upgrade fish?!

---

Reply to this email directly or view it on GitHub:
#14 (comment)

Sent from my phone

[justinmayer]

I don't think supporting fish 1.x should be a goal — the differences between it and 2.x are very significant.

Plus, since there is now an official PPA, it is very easy to install the latest fish 2.x release on Ubuntu 12.04 LTS.

[daisylb]

I agree. Thanks for the PPA tip, by the way - I've added a link to it in the readme.