Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document fallback with example styles #73

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Document fallback with example styles #73

merged 1 commit into from
Jan 4, 2023

Commits on Dec 2, 2022

  1. Document fallback with example styles 

    As discussed on justinribeiro#71, there's not much the component can do itself to provide a fallback, but it's very valuable to document how the fallback works for people less familiar with web components.

This adds a prominent example and educational info that will hopefully encourage people to provide a fallback for the numerous instances when it might be needed. It includes some [opinionated example styles](https://codepen.io/mrwweb/pen/qBKQOPW) which specifically call out using `aspect-ratio` to match the normal dimensions of a YouTube embed.

Adding this documentation feels like enough to satisfy justinribeiro#71 in my opinion, but I'd like to hear @simevidas weigh in on that too.

Additional minor change: remove whitespace at start of lines in playlist example that no other example code has.
    @mrwweb
    mrwweb authored Dec 2, 2022
    Configuration menu
    Copy the full SHA
    b36c7c7 View commit details
    Browse the repository at this point in the history