Use niv to pin dependencies.

[dhess]

This unifies all the various fetchFromGitHub instances scattered
across the multiple .nix files into a single, canonical source for
each dependency. It also pins the nixpkgs used to build the package,
to reduce impurities.

[justinwoo]

I do not use niv and do not plan to ever use niv, so I don't see any merging of this PR in the future happening. Do you have some specific wishes otherwise?

…

On Sun, Oct 11, 2020, 17:05 Drew Hess ***@***.***> wrote: This unifies all the various fetchFromGitHub instances scattered across the multiple .nix files into a single, canonical source for each dependency. It also pins the nixpkgs used to build the package, to reduce impurities. ------------------------------ You can view, comment on, or merge this pull request online at: #35 Commit Summary - Use niv to pin dependencies. File Changes - *M* build-project.nix <https://github.com/justinwoo/spago2nix/pull/35/files#diff-7bf197c54758c587978d59bd88cc6dcb> (13) - *M* ci.nix <https://github.com/justinwoo/spago2nix/pull/35/files#diff-2cb4bb20d0700c6703386de1d0107da3> (13) - *M* default.nix <https://github.com/justinwoo/spago2nix/pull/35/files#diff-5712e736e0de6ba170577f8472c398e9> (30) - *M* mkbin.nix <https://github.com/justinwoo/spago2nix/pull/35/files#diff-cd37d4b4c657c70c66430728f24b4b18> (12) - *A* nix/sources.json <https://github.com/justinwoo/spago2nix/pull/35/files#diff-debf2515aa28333d67d812df752012a4> (50) - *A* nix/sources.nix <https://github.com/justinwoo/spago2nix/pull/35/files#diff-595364ac09ff06d1b8c1533b2302cfa0> (174) Patch Links: - https://github.com/justinwoo/spago2nix/pull/35.patch - https://github.com/justinwoo/spago2nix/pull/35.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#35>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASJF7TSQKYWLCWVBZ4GSPLSKG3TNANCNFSM4SLZKHEA> .

[dhess]

Yes. In the current tree, there are at least 3 different places where fetchFromGitHub is used to fetch easy-purescript-nix. If you want to update the version that's being fetched, you have to a) update the rev and sha256 at each location, and b) be disciplined to keep them in sync.

It would also be nice to pin the nixpkgs used, rather than doing an impure import <nixpkgs> {} at the top of each Nix file, though that's mostly down to preference and not particularly a maintenance issue.

[justinwoo]

Yes, I agree easy purescript nix should be imported once in one file and the same pinned nixpkgs should be used as default in all files

…

On Sun, Oct 11, 2020, 17:19 Drew Hess ***@***.***> wrote: Yes. In the current tree, there are at least 3 different places where fetchFromGitHub is used to fetch easy-purescript-nix. If you want to update the version that's being fetched, you have to a) update the rev and sha256 at each location, and b) be disciplined to keep them in sync. It would also be nice to pin the nixpkgs used, rather than doing an impure import <nixpkgs> {} at the top of each Nix file, though that's mostly down to preference and not particularly a maintenance issue. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASJF7QCJSANP7XRSSKPW5TSKG5IHANCNFSM4SLZKHEA> .

[dhess]

So it sounds like you agree with the change in principle, but object to the implementation, is that right?

[justinwoo]

Sorry, do you mean to come off as rude in this comment? I believe this is basically what we have been discussing here.

…

On Sun, Oct 11, 2020, 17:23 Drew Hess ***@***.***> wrote: So it sounds like you agree with the change in principle, but object to the implementation, is that right? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASJF7SZDXU4NUHNZPIYOB3SKG5W3ANCNFSM4SLZKHEA> .

[dhess]

I'm just trying to work with you here, Justin. I find it difficult to figure out what you want from contributors.