-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lib-oer): return an error when unencoded size not in range #13
Merged
justmoon
merged 6 commits into
justmoon:main
from
sublimator:nd-convert-one-test-2022-12-11
Dec 19, 2022
Merged
fix(lib-oer): return an error when unencoded size not in range #13
justmoon
merged 6 commits into
justmoon:main
from
sublimator:nd-convert-one-test-2022-12-11
Dec 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sublimator
commented
Dec 11, 2022
sublimator
changed the title
feat(lib-oer): convert one test to use inline snapshots
fix(lib-oer): return an error when unencoded size not in range
Dec 12, 2022
sublimator
commented
Dec 12, 2022
expect(value).toMatchSnapshot() | ||
expect(value).toMatchInlineSnapshot(` | ||
{ | ||
"error": [SerializeError: String is too short, expected at least 13 characters, got 12], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This on right path?
sublimator
commented
Dec 13, 2022
tunsira
approved these changes
Dec 19, 2022
tunsira
reviewed
Dec 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.