Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1 Upgrade #373

Closed
Winfle opened this issue Sep 19, 2022 · 6 comments
Closed

PHP 8.1 Upgrade #373

Winfle opened this issue Sep 19, 2022 · 6 comments
Labels
php php8

Comments

@Winfle
Copy link

Winfle commented Sep 19, 2022

Guys, please add a php 8.1 upgrade, it crashes..
@dmitrii-fediuk
Copy link
Contributor

Please provide the exact error message.

@Winfle
Copy link
Author

Winfle commented Sep 20, 2022

[2022-09-20T21:16:34.420286+00:00] report.CRITICAL: Exception: Deprecated Functionality: mb_strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /app/vendor/justuno.com/core/lib/Core/text/starts-ends.php on line 34 in /app/vendor/magento/framework/App/ErrorHandler.php:61

There are a lot of them, please check setup:di:compile comand

@Winfle
Copy link
Author

Winfle commented Sep 20, 2022

Especially classes, that implement ArrayAccess interface

@Winfle
Copy link
Author

Winfle commented Sep 25, 2022

@dmitry-fedyuk Do you have a plan to fix this one?
Or it is better to fix it by our own?
Just asking, because it's quite Magento upgrade blocker for us, so we don't really have a time..
Thanks

@dmitrii-fediuk
Copy link
Contributor

@socks415 Do we need PHP 8.1 support?

This was referenced Oct 18, 2022
Closed
Closed
Open
@dmitrii-fediuk dmitrii-fediuk mentioned this issue Nov 29, 2022
Closed
This was referenced Nov 29, 2022
Closed
Closed
Closed
Closed
dmitrii-fediuk added a commit that referenced this issue Nov 30, 2022
@dmitrii-fediuk
1.3.0: #373
8d88eb7
dmitrii-fediuk added a commit to JustunoCom/m2 that referenced this issue Nov 30, 2022
@dmitrii-fediuk
1.8.0: justuno-com/core#373
98c50f5
dmitrii-fediuk added a commit to JustunoCom/magento-2-v4 that referenced this issue Nov 30, 2022
@dmitrii-fediuk
1.1.0: justuno-com/core#373
7512404
socks415 added a commit to JustunoCom/magento-2-v4 that referenced this issue Dec 7, 2022
@socks415
Merge pull request #5 from JustunoCom/2022-11-30
e9d17f9 
justuno-com/core#373
@dmitrii-fediuk
Copy link
Contributor

Done in 1.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
php php8
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitrii-fediuk @Winfle