Test and document nested objects #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -162,6 +162,9 @@ In this case, Juttle will issue a query against ES that matches documents whose | |||
| * `reduce by fieldname` (other than reduce by document type) | |||
| * `reduce -every :interval:` | |||
|
|
|||
| ##### Optimization and nested objects | |||
| There are a few fundamental incompatibilities between [Elasticsearch's model](https://www.elastic.co/guide/en/elasticsearch/guide/current/complex-core-fields.html) for nested object and array fields and [Juttle's](http://juttle.github.io/juttle/concepts/fields/#fields-with-object-or-array-values). This can lead to some odd results for optimized programs. For objects, an optimized `reduce by some_object_field` will return `null` as the only value for `some_object_field`. For arrays, an optimized `reduce by some_array_field` will return a separate value for `some_array_field` for every element in every array stored in `some_array_field`. | |||
|
|
|||
There was a problem hiding this comment.
Advice for how to get better behavior would be fitting here. Perhaps:
For results conforming to Juttle's `reduce` behavior, if reducing by an object or array field, make the reduce follow unoptimized path by adding `put unoptimized = true` before the `reduce by some_object_or_array_field`.
(My read of the situation is that we don't have a way to force the program to do that, because by the time we discover that was an object field, it's too late; hence, the user has to do that.)
|
Fwiw I don't have a problem with merging in skipped tests because they are waiting on a dependency. Additionally we can (should) file an issue for that work so it doesn't get forgotten. |
also warn if you reduce by an object field
davidvgalbraith
force-pushed
the
nest
branch
from
063708b
to
007df47
Compare
davidvgalbraith
added a commit
that referenced
this pull request
Feb 14, 2016
Test and document nested objects
|
Great! I opened #100. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also warn if you reduce by an object field. Most of the tests are skipped because of juttle/juttle#320. I'll open this PR so I don't forget about it, but probably not ready for merge unless we want a bunch of skipped tests in there.