Snap: Fix-up application icon lookup #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently snapd/snapcraft doesn't do much on making the application icon lookup works without manually patching the desktop entry. This patch does the patching in the prime step using a scriptlet. Fixes juzzlin#14. Refer-to: Application icon doesn't work in the launcher - snapcraft - snapcraft.io <https://forum.snapcraft.io/t/application-icon-doesnt-work-in-the-launcher/7292/7> Refer-to: Scriptlets - doc - snapcraft.io <https://forum.snapcraft.io/t/scriptlets/4892> Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
brlin-tw
force-pushed
the
patch-fixup-icon
branch
from
bce35f7
to
203ef51
Compare
|
Seems to work. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently snapd/snapcraft doesn't do much on making the application icon
lookup works without manually patching the desktop entry. This patch
does the patching in the prime step using a scriptlet.
Fixes #14.
Refer-to: Application icon doesn't work in the launcher - snapcraft -
snapcraft.io
https://forum.snapcraft.io/t/application-icon-doesnt-work-in-the-launcher/7292/7
Refer-to: Scriptlets - doc - snapcraft.io
https://forum.snapcraft.io/t/scriptlets/4892
Signed-off-by: 林博仁(Buo-ren Lin) Buo.Ren.Lin@gmail.com