-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented composite pattern for filesystem #256
Conversation
@rhazn FYI, since you are on leave, i requested Felix for an Review :) |
Thank you, if this is still open next week ping me and I can take a look then as well. If Felix is fine with it that's enough as well of course. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid the instanceof
checks, consider introducing new methods in FileSystemNode
that perform the recursive descents. Those can then be called in the FileSystem
class.
Also I think that paths should generally be treated case-sensitive.
libs/execution/src/lib/types/io-types/filesystem-node-directory.ts
Outdated
Show resolved
Hide resolved
libs/execution/src/lib/types/io-types/filesystem-node-directory.ts
Outdated
Show resolved
Hide resolved
libs/execution/src/lib/types/io-types/filesystem-node-directory.ts
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Felix Quast <51856713+felix-oq@users.noreply.github.com>
Co-authored-by: Felix Quast <51856713+felix-oq@users.noreply.github.com>
Co-authored-by: Felix Quast <51856713+felix-oq@users.noreply.github.com>
Co-authored-by: Felix Quast <51856713+felix-oq@users.noreply.github.com>
all implemented with new commits including Design for uniformity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more hints for improving the implementation, but otherwise this is good to go.
libs/execution/src/lib/types/io-types/filesystem-node-directory.ts
Outdated
Show resolved
Hide resolved
…alue/jayvee into feat-filesystem-as-compositum
closes #131
extends #123 and #219
Introduces a clean composite pattern for all filesystem related artefacts like it is done in ADAP.
The naming convention of the .ts-files yields the class-hierachy, so it is easier to understand.