fix(test): clip shift size to 31 bits on arm #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in
test_utils.rs
on arm devices in the overflow test.Left shift value should be clipped at 31 to avoid overflow when performing left-shift on arm - as
usize
on arm is 32-bits.Note that this case actually never occurs (as we pass
1 << 25
when dealing withf32
values, but the clipping is necessary to compile the.unwrap_or
)