Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): pass struct to tests instead of method #36

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Conversation

jvdd
Copy link
Owner

@jvdd jvdd commented Mar 4, 2023

Refactors how the shared test code (in test_utils.rs) is called.

Previously we passed the functions to this test method, but since #35 it is more clean to pass the structs that implement SIMDArgMinMax or ScalarArgMinMax
-> this allows more flexible updates to the tests (e.g, when supporting a new method)

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 4, 2023

CodSpeed Performance Report

Merging #36 test_updates (4bb70aa) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 52 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@jvdd jvdd merged commit 10ea33f into main Mar 4, 2023
@jvdd jvdd deleted the test_updates branch March 26, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant