Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 impl argmin & argmax in public traits #45

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Conversation

jvdd
Copy link
Owner

@jvdd jvdd commented Mar 26, 2023

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 26, 2023

CodSpeed Performance Report

Merging #45 impl_argmin_and_argmax (90c7305) will improve performances by 2.8%.

Summary

🔥 20 improvements
❌ 0 regressions
✅ 136 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

Benchmarks breakdown

Benchmark main impl_argmin_and_argmax Change
🔥 impl_u64_argmin 826 µs 697.8 µs 15.53%
🔥 impl_u64_argmax 826 µs 697.7 µs 15.53%
🔥 impl_u32_argmin 403.1 µs 349.5 µs 13.31%
🔥 impl_u32_argmax 403.1 µs 349.4 µs 13.32%
🔥 impl_f32_argmin_in 403.2 µs 323 µs 19.91%
🔥 impl_f32_argmax_in 403.2 µs 323 µs 19.90%
🔥 impl_i8_argmin 268.2 µs 165.9 µs 38.14%
🔥 impl_i8_argmax 268.2 µs 165.9 µs 38.15%
🔥 impl_u8_argmin 275.8 µs 173.5 µs 37.09%
🔥 impl_u8_argmax 275.8 µs 176.5 µs 35.99%
🔥 impl_i32_argmin 403 µs 322.8 µs 19.91%
🔥 impl_i32_argmax 403 µs 322.8 µs 19.91%
🔥 impl_u16_argmin 202.8 µs 165.3 µs 18.47%
🔥 impl_u16_argmax 202.8 µs 165.3 µs 18.46%
🔥 impl_f64_argmin_in 804.8 µs 644.7 µs 19.89%
🔥 impl_f64_argmax_in 804.8 µs 644.7 µs 19.89%
🔥 impl_i64_argmin 825.9 µs 697.7 µs 15.52%
🔥 impl_i64_argmax 825.9 µs 697.7 µs 15.52%
🔥 impl_i16_argmin 202.8 µs 164.8 µs 18.71%
🔥 impl_i16_argmax 202.8 µs 164.8 µs 18.73%

@jvdd jvdd merged commit 82206a2 into main Mar 26, 2023
@jvdd jvdd deleted the impl_argmin_and_argmax branch April 15, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant