Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readd flake8 to style tests #5

Merged
merged 6 commits into from
Jan 21, 2022
Merged

Readd flake8 to style tests #5

merged 6 commits into from
Jan 21, 2022

Conversation

guzman-raphael
Copy link

@guzman-raphael guzman-raphael commented Jan 21, 2022 •
edited
Loading

  • Readd since flake8 does more than just formatting and black is strictly just for code formatting.
  • Apparently W503 is not PEP8 compliant. Removing from style tests.
  • Noticed that our syntax/style tests aren't running against our tests module. Included it now.
  • Apparently, there is some issue around running style tests with pytest fixtures. Disabling F401 and F811 for now but the solution maybe to work with the conftest.py file in the future.
  • Update docs
  • Bump version due to changelog

@jverswijver jverswijver merged commit 26617a4 into jverswijver:update_dynamic_api Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jverswijver jverswijver jverswijver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guzman-raphael @jverswijver