Update Non-selection Actions #70

shanedell · 2021-08-09T15:38:56Z

Update extension to cancel debug launch if version is not selected, instead of just selecting the latest
- Closes Not selecting from the version download should cancel the launch #64
Believe error message are at a good, comment if there are any that need changed otherwise
- Closes Improved error messages #38

…. have the extension exit silently whenever a program file or data file is not chosen, so cancel button is clicked or exit out of windows

.gitignore

jw3 · 2021-08-09T17:53:43Z

src/daffodilDebugger.ts

-        dapodilVersion = dapodilVersion?.includes("v") ? dapodilVersion : `v${dapodilVersion}`;
+
+        if (!dapodilVersion) {
+            throw new Error("You must select a version of the Daffodil Debugger to run");


We dont need an error if someone clicks outside the box or presses Esc to cancel. It just needs to abort the launch.

src/activateDaffodilDebug.ts

…elected

update code to cancel launch if no daffodil debugger version selected…

2038137

…. have the extension exit silently whenever a program file or data file is not chosen, so cancel button is clicked or exit out of windows

shanedell requested a review from jw3 August 9, 2021 15:39

dells-ctc added 3 commits August 9, 2021 11:42

make unit tests action not run on tags

4029247

delete unneeded comments

4e03210

fix unit tests ci

b470416

jw3 suggested changes Aug 9, 2021

View reviewed changes

Make sure dataFile does not get prompted for if programFile was not s…

bfecc51

…elected

jw3 merged commit d36e5a4 into master Aug 10, 2021

jw3 deleted the non-selection branch August 10, 2021 00:16

jw3 mentioned this pull request Aug 27, 2021

Canceling schema or data dialogs still launches backend, which then exits with error #113

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Non-selection Actions #70

Update Non-selection Actions #70

shanedell commented Aug 9, 2021 •

edited

Loading

jw3 Aug 9, 2021

Update Non-selection Actions #70

Update Non-selection Actions #70

Conversation

shanedell commented Aug 9, 2021 • edited Loading

jw3 Aug 9, 2021

Choose a reason for hiding this comment

shanedell commented Aug 9, 2021 •

edited

Loading