-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer a version of async-start as a function #43
Comments
The issue, for reference : (sorry about the accidental close and reopen) |
I have no problem with that at all, especially if it doesn't need to be a macro. Would you like to make the change? |
John Wiegley notifications@github.com writes:
Please be sure to not break existing code if you do that. Thanks. Thierry |
Yes, very true @thierryvolpiatto. |
I'll give it a shot next time I have a moment. I can implement it as a new function, no need to change the current one and risk breaking stuff. :) |
Artur Malabarba notifications@github.com writes:
Thanks. Thierry |
* async.el (async--procvar): New internal var. (async-start): Use it to move async-start to a function.
async-start is now a function (#43).
As part of adding optional asynchronous operations to Paradox, I check whether async is installed and ask the user to install it.
The problem is: since async was installed after Paradox, the macro async-start doesn't get expanded on byte-compile, and later leads to an error (byte-compiled code can't call macros).
I've found a hacky solution (quoting the macro call and calling eval on it), but it would be nice to have a proper one. From what I understand of the async-start code, there's no reason for it to be a macro, it could work just as well as a function.
Would it be possible to offer it (or offer an alternative) as a function?
The text was updated successfully, but these errors were encountered: