Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in handling single quotes #433

Closed
FrankRensen opened this issue May 11, 2023 · 4 comments
Closed

Error in handling single quotes #433

FrankRensen opened this issue May 11, 2023 · 4 comments
Assignees
Labels
bug Something isn't working Shipped

Comments

@FrankRensen
Copy link

I have this label defined in my AL code.
SetupMssg: Label '%1 %2 %3 %4 %5 or '''' (empty) should be setup';

This is included in de translation file as:

%1 %2 %3 %4 %5 or '' (empty) should be setup

After performing the action NAB: Update all XLF files, it shows in the nl-translation file as:

%1 %2 %3 %4 %5 or ' (empty) should be setup Source has been modified.

Versions used
VSCode: 1.78.1 (User setup)
AL Language extension for Microsoft Dynamics 365 Business Central: v11.0.787898
NAB AL Tools: v.1.20.0

To Reproduce
See above

Expected behavior
After performing the action NAB: Update all XLF files, it shows in the nl-translation file as:

%1 %2 %3 %4 %5 or '' (empty) should be setup
  • Does it happen all the time?
    Yes

  • Did it used to work?
    Never seen this before,

@FrankRensen FrankRensen added the bug Something isn't working label May 11, 2023
@jwikman
Copy link
Owner

jwikman commented May 11, 2023

Hi @FrankRensen,

I agree, this should work (but haven't seen that one before obviously).

I'll try to find some time to dig into it.

@jwikman
Copy link
Owner

jwikman commented May 12, 2023

Hi @FrankRensen,

I think I found the cause to this issue.

Try out the pre-release version v1.31.305121921 and see if this is solved for you as well.

@jwikman jwikman self-assigned this May 12, 2023
@jwikman jwikman added waiting for feedback Ships in a future version Ships in a future version Pre-Release Shipped as a Pre-Release on VSCode Marketplace and removed Ships in a future version Ships in a future version labels May 12, 2023
@FrankRensen
Copy link
Author

FrankRensen commented May 16, 2023 via email

@jwikman
Copy link
Owner

jwikman commented May 16, 2023

Great @FrankRensen, thanks for confirming!

@jwikman jwikman closed this as completed May 16, 2023
@jwikman jwikman added Shipped and removed Pre-Release Shipped as a Pre-Release on VSCode Marketplace labels Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Shipped
Projects
None yet
Development

No branches or pull requests

2 participants