Handle unknown therapy event error when running ciq_therapy_event.py #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyaw
force-pushed
the
topic/unknown-therapy-event
branch
from
2ccf021
to
f47421e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing Issue #52 ... Fixing issue with unknown "BG" therapy events.
Added a BGTherapyEvent and handled it similar to the way Bolus and CGM TherapyEvent are handled after noticing that I had "BG" type data in my tconnect events.
A few more notes.... I noticed that the objects BolusTherapyEvent was created differently than CGMTherapyEvent and the new BGTherapyEvent which made checking their class/type uniformly challenging. Went and made sure their parse methods were updated similarly, and went ahead and changed the check for equivalence from type() to isinstance since I was there.