Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back Ruby 2.5 support and CodeClimate coverage reports #464

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

anakinj
Copy link
Member

@anakinj anakinj commented Jan 4, 2022

Think we should take one step back in dropping older Ruby support, keeping the EOLed 2.5 support until it adds some problems for us. The gem works just fine with 2.5, no new fancy feature taken into use.

Also this PR brings back CodeClimate coverage reports.

@sourcelevel-bot
Copy link

SourceLevel has finished reviewing this Pull Request and has found:

  • 5 possible new issues (including those that may have been commented here).

See more details about this review.

@anakinj
Copy link
Member Author

anakinj commented Jan 4, 2022

Also we should decide what to do with the CC_TEST_REPORTER_ID. Continue to keep it public, with the risk of anyone could push invalid coverage reports to the CodeClimate ruby-jwt project.

If we want to make it private we need to rotate it and add it to the project secrets and coverage runs will only be executed when PRs are merged to master.

The value in this PR was fetched from some old Travis CI log from an old coverage run.

EDIT: We are not really following the coverage that tight so we could as well make it only execute on merged PRs

@anakinj
Copy link
Member Author

anakinj commented Jan 4, 2022

Im going to merge this to see if we can get the coverage report moving. If we decide to still drop 2.5 we can do that later.

@anakinj anakinj merged commit 74ecfdc into jwt:master Jan 4, 2022
@anakinj
Copy link
Member Author

anakinj commented Jan 5, 2022

Apparently I had access to the CodeClimate repository. I've now rotated the CodeClimate TEST REPORTER ID.

So for now the coverage reports are only for master build. Could develop it a litte further to have some feedback on the PRs if the coverage goes down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant