relocated Services.java to impl module (along with tests). #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogeared
changed the title
bdemers
approved these changes
Oct 27, 2019
There was a problem hiding this comment.
This looks good to me, but I’m looking at the diffs on my phone, so take it with a grain of salt
One partial concern, UnavailableImplementationException is now in the impl package so it cannot be caught other then catching a generic JwtException.
This seems like a good thing, as there is a runtime config issue in these cases. So I’m +1 (it’s easy to change later if we need to expose it)
|
LGTM! |
lhazlewood
approved these changes
Oct 27, 2019
|
Ah, JDK8 is having coverage failure tests. Seems like something in the tests needs to be addressed. |
lhazlewood
requested changes
Oct 27, 2019
dogeared
force-pushed
the
524-move-services
branch
from
804a25f
to
4fbc5be
Compare
|
Tests should be address @lhazlewood - we'll see after this build... |
lhazlewood
approved these changes
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #524