Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from 'request' library to 'superagent' #3

Closed
wants to merge 1 commit into from

Conversation

isabek
Copy link
Contributor

@isabek isabek commented Feb 4, 2015

Added superagent module
Changed request to superagent module.
Fixed tests

Changed `request` to `superagent` module.
Fixed tests
@jxm262
Copy link
Owner

jxm262 commented Feb 4, 2015

Looks great, thanks! The only minor nitpick is in the tests 'xchange.test.js' you have the variable called 'superagent' which is different than the naming on the xchange.js implementation file (called 'request' there). I think you'd want to name the variable in this test file to 'request' to keep it the same. This also looks like how the superagent project has named the variable in their tests. Not a major thing though, just my initial thought.

Thanks again!

@jxm262 jxm262 closed this Feb 4, 2015
@isabek
Copy link
Contributor Author

isabek commented Feb 4, 2015

Oh. I will fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants