Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed up missing dependencies and updated README.md #232

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

ivanleomk
Copy link
Collaborator

@ivanleomk ivanleomk commented Nov 27, 2023

This fixes #184 and #231

Summary by CodeRabbit

  • New Features

    • Introduced new CLI commands for managing OpenAI fine-tuning jobs (instructor jobs).
    • Added file management capabilities via CLI (instructor files).
    • Enabled monitoring of OpenAI usage with a new CLI command (instructor usage).
  • Documentation

    • Updated CLI documentation to include new --model-suffix option and changes to --validation-file default value.
    • Added information on the integration of CLI tools with Pydantic and usage tracking in the project's main documentation.
  • Refactor

    • Improved CLI interface for better user experience.
  • Chores

    • Updated aiohttp and yarl libraries to newer versions for enhanced stability and performance.
    • Added rich and aiohttp to the project's dependencies.

Copy link
Contributor

coderabbitai bot commented Nov 27, 2023

Walkthrough

The project has been updated to enhance its command-line interface, adding new commands for managing fine-tuning jobs, files, and usage with OpenAI's GPT3.5 models. The documentation now previews these CLI features, and dependencies have been updated to include rich and aiohttp, with version bumps for better performance and stability.

Changes

File Path Change Summary
README.md Added new CLI commands: instructor jobs, instructor files, instructor usage.
docs/cli/finetune.md Updated CLI options for fine-tuning: added --model-suffix, updated --validation-file default to "None".
docs/index.md Added bullet point highlighting new CLI tools integration.
requirements-doc.txt Updated aiohttp to 3.9.1 and yarl to 1.8.1.
requirements.txt Added rich and aiohttp dependencies.

Assessment against linked issues

Objective Addressed Explanation
#184: Add a preview of CLI features in the readme and quick start.

Poem

In the burrow of code, a rabbit did hop,
With CLI tools, it's productivity non-stop.
🎉 instructor commands, now in full bloom,
Managing AI jobs, right from your room. 🐇💻


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 4

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a09cbd7 and 38421d9.
Files ignored due to filter (1)
  • pyproject.toml
Files selected for processing (5)
  • README.md (1 hunks)
  • docs/cli/finetune.md (2 hunks)
  • docs/index.md (1 hunks)
  • requirements-doc.txt (1 hunks)
  • requirements.txt (1 hunks)
Files skipped from review due to trivial changes (3)
  • README.md
  • docs/index.md
  • requirements-doc.txt
Additional comments: 1
docs/cli/finetune.md (1)
  • 9-13: Please verify that the removal of the section inviting contributions for specific tasks (like "Adding filenames on upload") is intentional and aligns with the current project goals.

Comment on lines +4 to +5
aiohttp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider pinning the versions of the newly added dependencies rich and aiohttp to ensure consistent builds and avoid potential incompatibilities with future versions.

│ --validation-file TEXT Path to the validation file [default: None] │
│ --model-suffix TEXT Suffix to identify the model [default: None] │
│ --help Show this message and exit. │
╰────────────────────────────────────────────────────────────────────────────────
```

#### Usage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example usage command should be updated to include the --model-suffix option to demonstrate its usage, ensuring consistency with the documentation.


The --validation_file option in the example usage command should use a hyphen (--validation-file) to match the option format in the help message.

- --validation_file validation_data.jsonl
+ --validation-file validation_data.jsonl

Committable suggestion

IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
#### Usage
``#### Usage
``
</details>
<!-- suggestion_end -->
<!-- This is an auto-generated comment by CodeRabbit -->
---
The `create_from_id` command in the example usage should use hyphens (`create-from-id`) to match the actual command format.
```diff
- $ instructor jobs create_from_id <file_id> --validation_file <validation_file_id> --n_epochs 3 --batch_size 16 --learning_rate_multiplier 0.5
+ $ instructor jobs create-from-id <file_id> --validation-file <validation_file_id> --n-epochs 3 --batch-size 16 --learning-rate-multiplier 0.5

Committable suggestion

IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
#### Usage
$ instructor jobs create-from-id <file_id> --validation-file <validation_file_id> --n-epochs 3 --batch-size 16 --learning-rate-multiplier 0.5

@jxnl jxnl merged commit 9f6b928 into main Nov 27, 2023
8 checks passed
@jxnl jxnl deleted the fix-rich-dependency-and-update-readme branch November 27, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Add a preview of CLI features in the readme and quick start.
2 participants