When switch to insert mode cancel if buffer is readonly

[olymk2]

When I am in a buffer using command mode and switch to insert mode if the buffer is read only it causes issues.

Basically it should stay in command mode currently it seems to leave me in a mode that is neither insert or command mode so my keybindings no longer work.

Perhaps check current buffers status before changing mode no sense even trying to use insert mode if the buffer is read only.

[jyp]

Thanks for your suggestion!

[olymk2]

awesome that was quick, I will give it a try :)

[aspiwack]

(sorry to be late to the party, I'm slowly emerging from my holidays)

This is probably a bad idea, actually. It seems fairly common to create read-only buffer with custom key bindings (the magit-blame buffer is of this nature, I believe) the ability to turn to the insert state is a stop-gap measure to interact with such buffer when they are not recognised as requiring special state.

@olymk2 what are the issues you were referring to in your original request?

[olymk2]

basically it fails to switch to insert mode, and command mode no longer works so all my bindings no longer work.

Means i get stuck trying to remember the original emacs bindings because it fails to switch but does not maintain the current command state

[aspiwack]

Ouch! That's pretty unpleasant. I wonder why that is, though. But anway, I retract my objection, and if I get bitten by it, I'll report back in a separate issue.

[jyp]

Note I only disabled this for proper insert mode and not the special mode.

…

On Thu, Sep 6, 2018 at 8:58 AM Arnaud Spiwack ***@***.***> wrote: Ouch! That's pretty unpleasant. I wonder why that is, though. But anway, I retract my objection, and if I get bitten by it, I'll report back in a separate issue. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#40 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABsYwmvqnNmlaTFxejvVU0EIyHbd1QNks5uYMecgaJpZM4WQfB2> .