-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bundling sources #34
Comments
I am actually looking into this right now. The download URL should be updated to fetch from GitHub. I'll open a pull request here. |
Thanks. Let me know if you need a hand with anything. |
If NLopt is installed and this can be detected by pkg-config in the nloptr
configure script, then the source code of NLopt will not be downloaded.
Instead, nloptr will link to the existing NLopt installation.
The request of adding the NLopt source to the nloptr library has come up
before before. I have been hesitant to add the source code because (1) I
don't know how this would work with licensing, and (2) I don't want to
take credit for the NLopt code, since I did not write it.
I'll reconsider adding the NLopt source to the nloptr package the next time
I will try to make a submission to CRAN, which I plan to do end of August.
On 17 Jul 2017 6:50 p.m., "Max Kuhn" <notifications@github.com> wrote:
Thanks. Let me know if you need a hand with anything.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#34 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADlPAOAL8yNRMo524XBcaH3tXsO0pZIsks5sO4-TgaJpZM4OZDOI>
.
|
I think that @jspiewak 's PR will solve the issue that I'm having. It's more about the lack of reliability of the current url. |
There is a very easy fix: install |
I'll do that. However, I've had a lot of issues when I'm teaching a class to brand new R users. Either from binaries for |
That's a slightly shifted goal post, but could you not pre-preare binaries and host a local repo if you desire binaries? [ I don't disagree that macOS has issues with compiling package but that is a different can of worms. I just wanted to point out that for Travis the issue is indeed very easily fixable. ] |
Not a problem... I didn't really say anything originally about the binaries. It looks like a moot point. From #35
@jyypma Should I close this? |
Suggestion by @eddelbuettel here on astamm/nloptr#34
It failed again on travis
I'll try Dirk's suggestion |
There are two main advantages to it (and I so need to blog on this):
Both hold here for nloptr after we mod'ed the Of course, this mostly only helps those on platform rich enough to actually have lots of binaries (in decent shape). An under-appreciated feature of Travis is its Ubuntu basis: there are over 25k binary packages in the distro alone, a bunch of very useful PPAs (ie when you need or want newest g++ or clang) --- and in the R case the 5k r-cran-* binary packages provided by Michael Rutter. |
Closed by f8cba33 |
I've repeatedly had issues with the sources at http://ab-initio.mit.edu/nlopt being unavailable. It seems to consistently break travis builds.
Is it possible to bundle the sources in the R package to avoid this? I'm sure that this has been thought of or previously discussed but
lme4
and a few other widely downloaded packages depend onnloptr
.As an alternative, I might be able to get RStudio to host the sources so that we would have a more reliable link. Perhaps that could be a fallback download source in your build system.
The text was updated successfully, but these errors were encountered: