Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to depend on SOXS #3

Merged
merged 38 commits into from
Dec 14, 2016
Merged

Refactor to depend on SOXS #3

merged 38 commits into from
Dec 14, 2016

Conversation

jzuhone
Copy link
Owner

@jzuhone jzuhone commented Dec 14, 2016

This PR takes all of the machinery in pyXSIM that is identical to that in SOXS and relies on SOXS for this functionality instead. This includes:

  • APEC thermal models
  • Wisconsin-absorption cross section models ("wabs")
  • Writing SIMPUT files
  • Instrument simulation

It is still necessary to update the Astro-H/Hitomi responses and add background to ACIS-S.

@jzuhone
Explicit dependence on soxs
21b67cd
@jzuhone
Let SOXS handle this now
e5389a4
@jzuhone
Outsource APEC spectrum generation to SOXS
6fcdcf1
@jzuhone
Add soxs to testing
43ee791
@jzuhone
Has to be done this way
fb21c40
@jzuhone
Wrong order of arguments
abb1703
@jzuhone
Removing the gaussian smoothing here, don’t need it
e037a12
@jzuhone
These files are no longer necessary
f54742c
@jzuhone
Removing unused imports
3a81c10
@jzuhone
Working through the instrument refactor.
960cab1
@jzuhone
Make sky_center a required parameter
55da55f
@jzuhone
Bug fixes
aafc6a2
@jzuhone
Updated power-law test
620badf
@jzuhone
Updated docstring
0ffa9e7
@jzuhone
Bugfix
457928b
@jzuhone
Wrap these two functions up into one
85f39b2
@jzuhone
Add a space here
0ce476c
@jzuhone
Beta model tests pass
1234239
@jzuhone
Temporary way to get dev version of soxs for testing
7bb72b1
@jzuhone
Removing all traces of internal response file stuff
fde7690
@jzuhone
Moved these utilities in soxs
61246fe
@jzuhone
New answer test. Expect event tests to fail at this point.
fa060f0
@jzuhone
Fix up tests a bit
71f9db5
@jzuhone
Fixed background test
bd3f737
@jzuhone
Missed this one
9f73ae9
@jzuhone
Point source test works
15bfcf4
@jzuhone
Fixed power-law test
5a28265
@jzuhone
Replace this with the one from soxs
3a110b4
@jzuhone
Drop units of nH
fb09ad6
@jzuhone
units fix
e6bb586
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 72.615% when pulling 9fd83ec on soxs into 3f3679d on master.

@jzuhone jzuhone merged commit 9e1eaae into master Dec 14, 2016
@jzuhone jzuhone deleted the soxs branch June 13, 2017 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzuhone @coveralls