Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for unrecognized line issue, add support for reassemble packages #6

Merged
merged 6 commits into from
May 3, 2018

Conversation

johnzeng
Copy link
Contributor

Bug fix for #5 , the root cause is the gmatch function, I don't use it to get the value in a bulk so in the second call of recurse, gmatch will return the value of last bulk.(in this case, is 'select')

Also support highlighting value size, reply number, and whole multi-bulk reply.

Also support reassemble tcp package which is mentioned in #1 . you can dump such package by using

redis-bench -d 1500 -n 1

Make sure your network interface have a MTU of 1500, otherwise, change 1500 to a lager number.

@johnzeng
Copy link
Contributor Author

Looks like there are some conflicts, please use my latest code to resolve them.

@jzwinck jzwinck merged commit 34ac261 into jzwinck:master May 3, 2018
@jzwinck
Copy link
Owner

jzwinck commented May 3, 2018

@johnzeng and @krzychu135: please review the way I merged this (because there were conflicts which I had to manually resolve), and check that it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants