Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cobotta canon camera #17

Closed

Conversation

k-kimura
Copy link

@k-kimura k-kimura commented Jun 4, 2021

@k-okada からのコメントで
cobottaのcanonのカメラが立ち上がるようにしたPRです。
CC: @ykawamura96

@@ -0,0 +1,207 @@
cmake_minimum_required(VERSION 3.0.2)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,4 @@
<launch>
<node name="camera_ctrl_server" pkg="canon_camera" type="camera_ctrl_server.py" />
<!-- <node name="camera_server" pkg="canon_camera" type="camera_ctrl_server.py" /> -->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is commented out?

@@ -0,0 +1,64 @@
<?xml version="1.0"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<buildtool_depend>catkin</buildtool_depend>
<build_depend>rospy</build_depend>
<build_export_depend>rospy</build_export_depend>
<exec_depend>rospy</exec_depend>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add dependencies carefully


def __init__(self, hz=1.0, save_image=False):
# b-CAP Client
self.client = bcapclient.BCAPClient(host='133.11.216.228',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ip address must be provided via rosparam

r.sleep()

def get_image(self):
'''撮影し、イメージを獲得する
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use english comment


return None

# def get_image_func():
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove debug comment

@@ -0,0 +1,149 @@
#!/usr/bin/env python3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use python2 for melodic and python3 for noetic are preferred, see http://wiki.ros.org/UsingPython3/SourceCodeChanges#Changing_shebangs

@@ -0,0 +1,78 @@
'''
Software License Agreement (MIT License)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where these codes comes from? please create canon_camera/denso? /bcap? direcotry and put 3rd-party cond within there.

"\n",
"import tkinter\n",
"import tkinter.filedialog\n",
"from tkinter import Label\n",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this code for?

@@ -0,0 +1,21 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this file.

@@ -0,0 +1,840 @@
'''
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants