Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddingImages: add arbitrary dtype images #2

Merged
merged 2 commits into from
Mar 24, 2017
Merged

AddingImages: add arbitrary dtype images #2

merged 2 commits into from
Mar 24, 2017

Conversation

wkentaro
Copy link

@wkentaro wkentaro commented Mar 24, 2017 •
edited
Loading

  • Do dynamic scaling for float/double images
  • Support adding images whose encodings are same kind (ex. rgb8 + bgr8)

@wkentaro
Support adding images whose encodings are same kind
c380d5e 
- For example adding rgb8 + bgr8

- modified:   src/nodelet/adding_images_nodelet.cpp
@wkentaro
Do dynamic scaling for float/double images
fc1b798 
- src/nodelet/adding_images_nodelet.cpp
@wkentaro wkentaro mentioned this pull request Mar 24, 2017
Merged
@k-okada k-okada merged commit 3fda2e5 into k-okada:add_image_beta Mar 24, 2017
@k-okada
Copy link
Owner

k-okada commented Mar 24, 2017

thanks you, please also remove "info"

@wkentaro wkentaro deleted the add_image_beta branch March 24, 2017 07:59
@wkentaro
Copy link
Author

wkentaro commented Mar 24, 2017 •
edited
Loading

Can I remove it? Or should I rename it to camera_info?

@wkentaro
Copy link
Author

#3 is OK?

@k-okada
Copy link
Owner

k-okada commented Mar 24, 2017

thank you this is ok for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkentaro @k-okada