Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump logrus to v1.9.3 + remove buffer overflow workaround #3182

Closed
wants to merge 1 commit into from
Closed

Bump logrus to v1.9.3 + remove buffer overflow workaround #3182

wants to merge 1 commit into from

Conversation

kke
Copy link
Contributor

@kke kke commented Jun 5, 2023

Description

Reverts changes made in #2674 that were done to work around bug sirupsen/logrus#1370 in logrus that was fixed in sirupsen/logrus#1384 and released as v1.9.3

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@kke kke added the area/cli label Jun 5, 2023
@kke kke force-pushed the remove-logrus-writer-panic-workaround branch from bc3b819 to 52acbfb Compare June 5, 2023 07:28
@kke kke changed the title Revert workaround, upgrade logrus package to fix buffer overflow bug Remove redundant log buffer overflow workaround, use fix from upstream Jun 5, 2023
@kke kke changed the title Remove redundant log buffer overflow workaround, use fix from upstream Bump logrus to v1.9.3 and remove redundant buffer overflow bug workaround Jun 5, 2023
@kke kke changed the title Bump logrus to v1.9.3 and remove redundant buffer overflow bug workaround Bump logrus to v1.9.3 + remove redundant buffer overflow bug workaround Jun 5, 2023
@kke kke marked this pull request as ready for review June 5, 2023 08:03
@kke kke requested a review from a team as a code owner June 5, 2023 08:03
@kke kke requested review from makhov and twz123 June 5, 2023 08:03
@kke kke changed the title Bump logrus to v1.9.3 + remove redundant buffer overflow bug workaround Bump logrus to v1.9.3 + remove buffer overflow workaround Jun 5, 2023
makhov
makhov previously approved these changes Jun 5, 2023
View reviewed changes
@kke kke mentioned this pull request Jun 6, 2023
Closed
@twz123
Copy link
Member

twz123 commented Jun 6, 2023

I see two shortcomings with the upstream approach:

  1. the original log output cannot be recovered from the k0s logs, i.e. there is no way to determine how the output was chunked.
  2. it is not unicode-safe, i.e. it can split messages within unicode code points, which could corrupt logs.

@kke kke mentioned this pull request Jun 7, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Oct 8, 2023
@kke
Bump sirupsen/logrus to v1.9.3 and remove workaround
2b2261c 
Revert the buffer overflow workaround, which is no longer
needed with logrus v1.9.3.

Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke force-pushed the remove-logrus-writer-panic-workaround branch from 52acbfb to 2b2261c Compare October 10, 2023 06:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Nov 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Dec 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Jan 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Feb 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Mar 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Apr 14, 2024
@github-actions github-actions bot closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makhov makhov makhov left review comments

@twz123 twz123 Awaiting requested review from twz123 twz123 is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/cli Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kke @twz123 @makhov