Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build k0s Docker image on GitHub managed runners #3419

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Build k0s Docker image on GitHub managed runners #3419

merged 1 commit into from
Aug 25, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Aug 25, 2023

Description

There's no need to do it on the self-hosted runners and makes the job's maintenance easier. In fact, docker-buildx is not working properly on the self-hosted runners at the moment.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Build k0s Docker image on GitHub managed runners
fffa625 
There's no need to do it on the self-hosted runners and makes the job's
maintenance easier. In fact, docker-buildx is not working properly on
the self-hosted runners at the moment.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added bug Something isn't working area/ci labels Aug 25, 2023
@twz123 twz123 requested a review from a team as a code owner August 25, 2023 08:35
@twz123 twz123 added the backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch label Aug 25, 2023
@twz123 twz123 merged commit d3cf2bd into k0sproject:main Aug 25, 2023
73 checks passed
@twz123 twz123 deleted the build-image-on-managed-runners branch August 25, 2023 10:05
@k0s-bot
Copy link

k0s-bot commented Aug 25, 2023

Successfully created backport PR for release-1.27:

@k0s-bot k0s-bot mentioned this pull request Aug 25, 2023
Merged
This was referenced Aug 25, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

@mikhail-sakhnov mikhail-sakhnov Awaiting requested review from mikhail-sakhnov mikhail-sakhnov is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/ci backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twz123 @k0s-bot @jnummelin